Add support for Sentinel-2C #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
=======================================
Coverage 90.25% 90.25%
=======================================
Files 22 22
Lines 2515 2515
=======================================
Hits 2270 2270
Misses 245 245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
@adybbroe do you have the possibility to look at this? |
Signed-off-by: Adam.Dybbroe <[email protected]>
adybbroe
approved these changes
Sep 24, 2024
|
And here is an example plotting the SW spectral responses for all three satellites |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Sentinel-2C satellite.
In addition, the library used by the S2 RSR reader is outdated and does not work with XLSX files. So I changed to use pandas and openpyxl.
pytest pyspectralflake8 pyspectral